Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686783002: Remove almost all of Oilpan (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove almost all of Oilpan The only things left are all the baseclasses and macros in heap/Handle.h which are referenced throughout all of core. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2da1fc1a619299259ccd43457a11026130fc1ac6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2896 lines) Patch
M sky/engine/bindings/core/v8/DOMWrapperWorld.h View 2 chunks +2 lines, -1 line 0 comments Download
D sky/engine/bindings/core/v8/ScriptFunction.h View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/bindings/core/v8/ScriptFunction.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromise.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/v8.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSImageGeneratorValue.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/CSSValue.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/FontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/StylePropertySet.h View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/invalidation/StyleInvalidator.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/css/resolver/MediaQueryResult.h View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/EventHandlerRegistry.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/EventHandlerRegistry.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/style/DataEquivalency.h View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/platform/graphics/media/MediaPlayer.h View 1 chunk +1 line, -0 lines 0 comments Download
D sky/engine/platform/heap/AddressSanitizer.h View 1 chunk +0 lines, -65 lines 0 comments Download
M sky/engine/platform/heap/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download
D sky/engine/platform/heap/BlinkHeapUnitTests.isolate View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/engine/platform/heap/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/heap/Handle.h View 3 chunks +12 lines, -638 lines 0 comments Download
D sky/engine/platform/heap/ThreadState.h View 1 chunk +0 lines, -742 lines 0 comments Download
D sky/engine/platform/heap/Visitor.h View 1 chunk +0 lines, -601 lines 0 comments Download
D sky/engine/platform/heap/asm/SaveRegisters_arm.S View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/platform/heap/asm/SaveRegisters_arm64.S View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/platform/heap/asm/SaveRegisters_mips.S View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/platform/heap/asm/SaveRegisters_mips64.S View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/engine/platform/heap/asm/SaveRegisters_x86.asm View 1 chunk +0 lines, -155 lines 0 comments Download
D sky/engine/platform/heap/glue/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/engine/platform/heap/glue/PendingGCRunner.h View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/web/WebMediaPlayerClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/HashTable.h View 3 chunks +0 lines, -133 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-10-28 15:54:22 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-28 16:10:28 UTC) #2
eseidel
6 years, 1 month ago (2014-10-28 16:36:54 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2da1fc1a619299259ccd43457a11026130fc1ac6.

Powered by Google App Engine
This is Rietveld 408576698