components/password_manager/content/browser/content_password_manager_driver.h - Issue 686653003: Don't use FormFieldData only as a key in a map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.h

Issue 686653003: Don't use FormFieldData only as a key in a map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.h

diff --git a/components/password_manager/content/browser/content_password_manager_driver.h b/components/password_manager/content/browser/content_password_manager_driver.h

index c6b64f6fb5bba37d27c80c2c46b9b17bf33ff4a1..3d454a6d5d6a38d488304bafe92dc20d0530957b 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.h

+++ b/components/password_manager/content/browser/content_password_manager_driver.h

@@ -63,6 +63,12 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver,

PasswordGenerationManager password_generation_manager_;

PasswordAutofillManager password_autofill_manager_;

+ // Every instance of PasswordFormFillData created by |*this| and sent to

+ // PasswordAutofillManager and PasswordAutofillAgent is given an ID, so that

+ // the latter two classes can reference to the same instance without sending

+ // it to each other over IPC. The counter below is used to generate new IDs.

+ int next_free_key_;

DISALLOW_COPY_AND_ASSIGN(ContentPasswordManagerDriver);

};