Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 686653003: Don't use FormFieldData only as a key in a map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 0c0e348c297c2d9c6aa4b7ecc409c4eccd240c84..62c20e6eed31e3ac72466c800c421635e0b00d3d 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -27,7 +27,8 @@ ContentPasswordManagerDriver::ContentPasswordManagerDriver(
: WebContentsObserver(web_contents),
password_manager_(client),
password_generation_manager_(client),
- password_autofill_manager_(client, autofill_client) {
+ password_autofill_manager_(client, autofill_client),
+ next_free_key_(0) {
DCHECK(web_contents);
}
@@ -35,9 +36,11 @@ ContentPasswordManagerDriver::~ContentPasswordManagerDriver() {}
void ContentPasswordManagerDriver::FillPasswordForm(
const autofill::PasswordFormFillData& form_data) {
+ const int key = next_free_key_++;
+ password_autofill_manager_.OnAddPasswordFormMapping(key, form_data);
DCHECK(web_contents());
web_contents()->GetRenderViewHost()->Send(new AutofillMsg_FillPasswordForm(
- web_contents()->GetRenderViewHost()->GetRoutingID(), form_data));
+ web_contents()->GetRenderViewHost()->GetRoutingID(), key, form_data));
}
void ContentPasswordManagerDriver::AllowPasswordGenerationForForm(
@@ -133,9 +136,6 @@ bool ContentPasswordManagerDriver::OnMessageReceived(
IPC_MESSAGE_FORWARD(AutofillHostMsg_ShowPasswordSuggestions,
&password_autofill_manager_,
PasswordAutofillManager::OnShowPasswordSuggestions)
- IPC_MESSAGE_FORWARD(AutofillHostMsg_AddPasswordFormMapping,
- &password_autofill_manager_,
- PasswordAutofillManager::OnAddPasswordFormMapping)
IPC_MESSAGE_FORWARD(AutofillHostMsg_RecordSavePasswordProgress,
password_manager_.client(),
PasswordManagerClient::LogSavePasswordProgress)

Powered by Google App Engine
This is Rietveld 408576698