Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 686633002: First pass at removing position:fixed. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index aa511f7a8f5362619bb30cdb735b7fb24dcbaaaa..237b5f927c0a37c1ebd33cc4a958ce6b8ccae808 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -204,8 +204,6 @@ void RenderView::mapLocalToContainer(const RenderLayerModelObject* paintInvalida
const RenderObject* RenderView::pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap& geometryMap) const
{
- // FIXME(sky): Can we remove offsetForFixedPosition?
- LayoutSize offsetForFixedPosition;
LayoutSize offset;
RenderObject* container = 0;
@@ -216,9 +214,9 @@ const RenderObject* RenderView::pushMappingToContainer(const RenderLayerModelObj
if ((!ancestorToStopAt || container) && shouldUseTransformFromContainer(container)) {
TransformationMatrix t;
getTransformFromContainer(container, LayoutSize(), t);
- geometryMap.push(this, t, false, false, false, true, offsetForFixedPosition);
+ geometryMap.push(this, t, false, false, true);
} else {
- geometryMap.push(this, offset, false, false, false, false, offsetForFixedPosition);
+ geometryMap.push(this, offset, false, false, false);
}
return container;
« no previous file with comments | « sky/engine/core/rendering/RenderObject.cpp ('k') | sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698