Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4086)

Unified Diff: chrome/browser/ui/ash/screenshot_taker.cc

Issue 686563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/screenshot_taker.cc
diff --git a/chrome/browser/ui/ash/screenshot_taker.cc b/chrome/browser/ui/ash/screenshot_taker.cc
index f0e91c64c475da453cefb86e53b3c1fbfcb71921..0f6dfd760d101102dfff70433ed8e791377ade0f 100644
--- a/chrome/browser/ui/ash/screenshot_taker.cc
+++ b/chrome/browser/ui/ash/screenshot_taker.cc
@@ -127,10 +127,10 @@ class ScreenshotTakerNotificationDelegate : public NotificationDelegate {
}
// Overridden from NotificationDelegate:
- virtual void Display() override {}
- virtual void Error() override {}
- virtual void Close(bool by_user) override {}
- virtual void Click() override {
+ void Display() override {}
+ void Error() override {}
+ void Close(bool by_user) override {}
+ void Click() override {
if (!success_)
return;
#if defined(OS_CHROMEOS)
@@ -139,7 +139,7 @@ class ScreenshotTakerNotificationDelegate : public NotificationDelegate {
// TODO(sschmitz): perhaps add similar action for Windows.
#endif
}
- virtual void ButtonClick(int button_index) override {
+ void ButtonClick(int button_index) override {
DCHECK(success_ && button_index == 0);
// To avoid keeping the screenshot image on memory, it will re-read the
@@ -158,13 +158,11 @@ class ScreenshotTakerNotificationDelegate : public NotificationDelegate {
FROM_HERE, base::Bind(
&ReadFileAndCopyToClipboardLocal, screenshot_path_));
}
- virtual bool HasClickedListener() override { return success_; }
- virtual std::string id() const override {
- return std::string(kNotificationId);
- }
+ bool HasClickedListener() override { return success_; }
+ std::string id() const override { return std::string(kNotificationId); }
private:
- virtual ~ScreenshotTakerNotificationDelegate() {}
+ ~ScreenshotTakerNotificationDelegate() override {}
const bool success_;
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698