chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h - Issue 686563002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h

Issue 686563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/accessibility/automation_manager_ash.h ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h

index ef10c05e4c2192b0aeb74edb44662267e89299ae..25ab9046e04ddb2d38fdca4117e87911ab32867b 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h

@@ -27,8 +27,8 @@ class ChromeLauncherAppMenuItemV2App : public ChromeLauncherAppMenuItem {

ChromeLauncherController* launcher_controller,

int app_index,

bool has_leading_separator);

oshima 2014/10/27 23:35:43 This class should have dtor. would you mind adding

dcheng 2014/10/27 23:37:26 Ditto--would prefer to fix this in a separate patc

oshima 2014/10/27 23:53:29 This one should be safe though. ChromeLauncherAppM

- virtual bool IsEnabled() const override;

- virtual void Execute(int event_flags) override;

+ bool IsEnabled() const override;

+ void Execute(int event_flags) override;

private:

// The owning class which can be used to validate the controller.