chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc - Issue 686563002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

Issue 686563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h ('K') | « chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc ('k') | chrome/browser/ui/ash/launcher/launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

index 621d7d5bba9b4d53de7a2e83450c8251d1b62dd7..b490727bb1d10a298c5533b59a13fa2f686f29ca 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

@@ -32,15 +32,15 @@ class FaviconRawBitmapHandler : public content::WebContentsObserver {

delegate_(delegate),

weak_ptr_factory_(this) {}

- virtual ~FaviconRawBitmapHandler() {}

+ ~FaviconRawBitmapHandler() override {}

const SkBitmap& bitmap() const { return bitmap_; }

bool HasPendingDownloads() const;

// content::WebContentObserver implementation.

- virtual void DidUpdateFaviconURL(

- const std::vector<content::FaviconURL>& candidates) override;

+ void DidUpdateFaviconURL(

+ const std::vector<content::FaviconURL>& candidates) override;

private:

void DidDownloadFavicon(