chrome/browser/ui/ash/launcher/launcher_context_menu.h - Issue 686563002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu.h

Issue 686563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h ('K') | « chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h ('k') | chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_context_menu.h

diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu.h b/chrome/browser/ui/ash/launcher/launcher_context_menu.h

index f0fcdbd893f2cb1705e202e9dab81a72b6f1a800..9255ddca84a392ced6f5e5acf550c06b0e226198 100644

--- a/chrome/browser/ui/ash/launcher/launcher_context_menu.h

+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu.h

@@ -45,7 +45,7 @@ class LauncherContextMenu : public ui::SimpleMenuModel,

// Creates a menu used as a desktop context menu on |root_window|.

LauncherContextMenu(ChromeLauncherController* controller,

aura::Window* root_window);

- virtual ~LauncherContextMenu();

+ ~LauncherContextMenu() override;

void Init();

@@ -53,15 +53,14 @@ class LauncherContextMenu : public ui::SimpleMenuModel,

ash::ShelfID id() const { return item_.id; }

// ui::SimpleMenuModel::Delegate overrides:

- virtual bool IsItemForCommandIdDynamic(int command_id) const override;

- virtual base::string16 GetLabelForCommandId(int command_id) const override;

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual bool IsCommandIdEnabled(int command_id) const override;

- virtual bool IsCommandIdVisible(int command_id) const override;

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) override;

- virtual void ExecuteCommand(int command_id, int event_flags) override;

+ bool IsItemForCommandIdDynamic(int command_id) const override;

+ base::string16 GetLabelForCommandId(int command_id) const override;

+ bool IsCommandIdChecked(int command_id) const override;

+ bool IsCommandIdEnabled(int command_id) const override;

+ bool IsCommandIdVisible(int command_id) const override;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override;

+ void ExecuteCommand(int command_id, int event_flags) override;

private:

FRIEND_TEST_ALL_PREFIXES(