chrome/browser/ui/ash/launcher/app_window_launcher_controller.h - Issue 686563002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/app_window_launcher_controller.h

Issue 686563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/accessibility/automation_manager_ash.h ('K') | « chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h ('k') | chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h » ('j') | chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/app_window_launcher_controller.h

diff --git a/chrome/browser/ui/ash/launcher/app_window_launcher_controller.h b/chrome/browser/ui/ash/launcher/app_window_launcher_controller.h

index 9fd428d34174664768ee94dae1db41c3f1fc1a3b..8f2ca87ab6953cd9dcd3d144df6d77f85920a3c0 100644

--- a/chrome/browser/ui/ash/launcher/app_window_launcher_controller.h

+++ b/chrome/browser/ui/ash/launcher/app_window_launcher_controller.h

@@ -39,7 +39,7 @@ class AppWindowLauncherController

public aura::client::ActivationChangeObserver {

public:

explicit AppWindowLauncherController(ChromeLauncherController* owner);

- virtual ~AppWindowLauncherController();

+ ~AppWindowLauncherController() override;

// Called by ChromeLauncherController when the active user changed and the

// items need to be updated.

@@ -50,17 +50,16 @@ class AppWindowLauncherController

virtual void AdditionalUserAddedToSession(Profile* profile);

// Overridden from AppWindowRegistry::Observer:

- virtual void OnAppWindowIconChanged(

- extensions::AppWindow* app_window) override;

- virtual void OnAppWindowShown(extensions::AppWindow* app_window) override;

- virtual void OnAppWindowHidden(extensions::AppWindow* app_window) override;

+ void OnAppWindowIconChanged(extensions::AppWindow* app_window) override;

+ void OnAppWindowShown(extensions::AppWindow* app_window) override;

+ void OnAppWindowHidden(extensions::AppWindow* app_window) override;

// Overriden from aura::WindowObserver:

- virtual void OnWindowDestroying(aura::Window* window) override;

+ void OnWindowDestroying(aura::Window* window) override;

// Overriden from client::ActivationChangeObserver:

- virtual void OnWindowActivated(aura::Window* gained_active,

- aura::Window* lost_active) override;

+ void OnWindowActivated(aura::Window* gained_active,

+ aura::Window* lost_active) override;

protected:

// Registers a app window with the shelf and this object.