Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686423003: Build SkThreadUtils (home of SkThread type) too. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Build SkThreadUtils (home of SkThread type) too. BUG= Committed: https://crrev.com/f922e95f9f8d3a3bcf4c7465832f1cd229179dc7 Cr-Commit-Position: refs/heads/master@{#302095}

Patch Set 1 #

Patch Set 2 : proper conditionals? #

Patch Set 3 : simplify #

Patch Set 4 : gyp is relative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M skia/BUILD.gn View 1 2 1 chunk +17 lines, -9 lines 0 comments Download
M skia/skia_library.gypi View 1 2 3 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein
6 years, 1 month ago (2014-10-30 13:50:58 UTC) #2
reed1
lgtm
6 years, 1 month ago (2014-10-30 13:59:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686423003/1
6 years, 1 month ago (2014-10-30 14:00:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/29675)
6 years, 1 month ago (2014-10-30 14:05:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686423003/20001
6 years, 1 month ago (2014-10-30 15:07:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/29699)
6 years, 1 month ago (2014-10-30 15:12:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686423003/60001
6 years, 1 month ago (2014-10-30 15:27:34 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-30 16:58:24 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 16:59:02 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f922e95f9f8d3a3bcf4c7465832f1cd229179dc7
Cr-Commit-Position: refs/heads/master@{#302095}

Powered by Google App Engine
This is Rietveld 408576698