Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: skia/skia_library.gypi

Issue 686423003: Build SkThreadUtils (home of SkThread type) too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gyp is relative Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia_library.gypi
diff --git a/skia/skia_library.gypi b/skia/skia_library.gypi
index 88fa22248a5aac3ce8dc77802fc00ef8d11d6569..6879cfc5324943a82c754825eb2cca54141535a1 100644
--- a/skia/skia_library.gypi
+++ b/skia/skia_library.gypi
@@ -132,17 +132,13 @@
'../third_party/skia/src/utils/SkPathUtils.cpp',
'../third_party/skia/src/utils/SkSHA1.cpp',
'../third_party/skia/src/utils/SkSHA1.h',
- '../third_party/skia/src/utils/SkThreadUtils.h',
- '../third_party/skia/src/utils/SkThreadUtils_pthread.cpp',
- '../third_party/skia/src/utils/SkThreadUtils_pthread.h',
- '../third_party/skia/src/utils/SkThreadUtils_pthread_linux.cpp',
- '../third_party/skia/src/utils/SkThreadUtils_pthread_mach.cpp',
- '../third_party/skia/src/utils/SkThreadUtils_pthread_other.cpp',
- '../third_party/skia/src/utils/SkThreadUtils_win.cpp',
- '../third_party/skia/src/utils/SkThreadUtils_win.h',
'../third_party/skia/src/utils/SkTFitsIn.h',
'../third_party/skia/src/utils/SkTLogic.h',
+ # We don't currently need to change thread affinity, so leave out this complexity for now.
+ "../third_party/skia/src/utils/SkThreadUtils_pthread_mach.cpp",
+ "../third_party/skia/src/utils/SkThreadUtils_pthread_linux.cpp",
+
#windows
'../third_party/skia/include/utils/win/SkAutoCoInitialize.h',
'../third_party/skia/include/utils/win/SkHRESULT.h',
@@ -202,6 +198,19 @@
],
}],
+ [ 'OS == "win"', {
+ 'sources!': [
+ # Keeping _win.cpp
+ "../third_party/skia/src/utils/SkThreadUtils_pthread.cpp",
+ "../third_party/skia/src/utils/SkThreadUtils_pthread_other.cpp",
+ ],
+ },{
+ 'sources!': [
+ # Keeping _pthread.cpp and _pthread_other.cpp
+ "../third_party/skia/src/utils/SkThreadUtils_win.cpp",
+ ],
+ }],
+
[ 'OS != "mac"', {
'sources/': [
['exclude', '/mac/']
« no previous file with comments | « skia/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698