Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: minidump/minidump_thread_writer_test.cc

Issue 686353004: Add MinidumpContextWriter::CreateFromSnapshot(), everything downstream, and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_exception_writer_test.cc ('k') | minidump/test/minidump_context_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_thread_writer_test.cc
diff --git a/minidump/minidump_thread_writer_test.cc b/minidump/minidump_thread_writer_test.cc
index 0e2458d3b69bad367260820f20968436e2f4c6c5..6dc065e76b6abdff31d3d03ac611f8c65dd90482 100644
--- a/minidump/minidump_thread_writer_test.cc
+++ b/minidump/minidump_thread_writer_test.cc
@@ -184,7 +184,8 @@ TEST(MinidumpThreadWriter, OneThread_x86_NoStack) {
nullptr,
reinterpret_cast<const void**>(&observed_context)));
- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed, observed_context));
+ ASSERT_NO_FATAL_FAILURE(
+ ExpectMinidumpContextX86(kSeed, observed_context, false));
}
TEST(MinidumpThreadWriter, OneThread_AMD64_Stack) {
@@ -258,7 +259,8 @@ TEST(MinidumpThreadWriter, OneThread_AMD64_Stack) {
file_writer.string(),
kMemoryValue,
true));
- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextAMD64(kSeed, observed_context));
+ ASSERT_NO_FATAL_FAILURE(
+ ExpectMinidumpContextAMD64(kSeed, observed_context, false));
}
TEST(MinidumpThreadWriter, ThreeThreads_x86_MemoryList) {
@@ -398,7 +400,8 @@ TEST(MinidumpThreadWriter, ThreeThreads_x86_MemoryList) {
file_writer.string(),
kMemoryValue0,
false));
- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed0, observed_context));
+ ASSERT_NO_FATAL_FAILURE(
+ ExpectMinidumpContextX86(kSeed0, observed_context, false));
ASSERT_NO_FATAL_FAILURE(ExpectMinidumpMemoryDescriptor(
observed_stack, &memory_list->MemoryRanges[0]));
}
@@ -431,7 +434,8 @@ TEST(MinidumpThreadWriter, ThreeThreads_x86_MemoryList) {
file_writer.string(),
kMemoryValue1,
false));
- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed1, observed_context));
+ ASSERT_NO_FATAL_FAILURE(
+ ExpectMinidumpContextX86(kSeed1, observed_context, false));
ASSERT_NO_FATAL_FAILURE(ExpectMinidumpMemoryDescriptor(
observed_stack, &memory_list->MemoryRanges[1]));
}
@@ -464,7 +468,8 @@ TEST(MinidumpThreadWriter, ThreeThreads_x86_MemoryList) {
file_writer.string(),
kMemoryValue2,
true));
- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed2, observed_context));
+ ASSERT_NO_FATAL_FAILURE(
+ ExpectMinidumpContextX86(kSeed2, observed_context, false));
ASSERT_NO_FATAL_FAILURE(ExpectMinidumpMemoryDescriptor(
observed_stack, &memory_list->MemoryRanges[2]));
}
« no previous file with comments | « minidump/minidump_exception_writer_test.cc ('k') | minidump/test/minidump_context_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698