minidump/minidump_exception_writer_test.cc - Issue 686353004: Add MinidumpContextWriter::CreateFromSnapshot(), everything downstream, and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_exception_writer_test.cc

Issue 686353004: Add MinidumpContextWriter::CreateFromSnapshot(), everything downstream, and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_exception_writer_test.cc

diff --git a/minidump/minidump_exception_writer_test.cc b/minidump/minidump_exception_writer_test.cc

index ce41fb4c398e7d1d7fca983a7224cf118323a964..ad523f0767c9d77d99d4a5d51955f4d6bf690224 100644

--- a/minidump/minidump_exception_writer_test.cc

+++ b/minidump/minidump_exception_writer_test.cc

@@ -119,7 +119,8 @@ TEST(MinidumpExceptionWriter, Minimal) {

file_writer.string(),

&observed_context));

- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed, observed_context));

+ ASSERT_NO_FATAL_FAILURE(

+ ExpectMinidumpContextX86(kSeed, observed_context, false));

}

TEST(MinidumpExceptionWriter, Standard) {

@@ -189,7 +190,8 @@ TEST(MinidumpExceptionWriter, Standard) {

file_writer.string(),

&observed_context));

- ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed, observed_context));

+ ASSERT_NO_FATAL_FAILURE(

+ ExpectMinidumpContextX86(kSeed, observed_context, false));

}

TEST(MinidumpExceptionWriterDeathTest, NoContext) {

« no previous file with comments | « minidump/minidump_context_writer_test.cc ('k') | minidump/minidump_thread_writer_test.cc » ('j') | no next file with comments »