Issue 686263002: Revert of scale xmin/xmax etc in fontmetrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686263002: Revert of scale xmin/xmax etc in fontmetrics (Closed)

Created:
6 years, 1 month ago by bungeman-skia

Modified:
6 years, 1 month ago

Reviewers:
reed2

CC:
reviews_skia.org, mtklein

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of scale xmin/xmax etc in fontmetrics (patchset #1 id:1 of https://codereview.chromium.org/690533004/) Reason for revert: Breaking tests in Chromium, and not in a good way. Original issue's description: > scale xmin/xmax etc in fontmetrics > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/f8c2feffd68b3262f3c039ec1bd517c5f6cc9e4c TBR=reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/7316b100dfd2a0f9553e7f1e9f3a5f4c46b8e4db

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of scale xmin/xmax etc in fontmetrics

6 years, 1 month ago (2014-10-29 19:34:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686263002/1

6 years, 1 month ago (2014-10-29 19:35:39 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 19:46:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 7316b100dfd2a0f9553e7f1e9f3a5f4c46b8e4db