Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 686173006: Ignore ::first-letter from ancestors in grids and flexboxes (Closed)

Created:
6 years, 1 month ago by Manuel Rego
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, cbiesinger, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Ignore ::first-letter from ancestors in grids and flexboxes According to the grid and flexbox specs: "the ::first-line and ::first-letter pseudo-elements do not apply to grid/flex containers". http://dev.w3.org/csswg/css-grid/#grid-containers http://dev.w3.org/csswg/css-flexbox/#flex-containers This was almost working right, except in the case that an ancestor was setting the ::first-letter pseudo-element. Modified RenderBlock::updateFirstLetter() in order to stop looking for the first text child when you reach a grid or flexbox. Added a few more cases to the current tests in order to check this behavior. TEST=css3/flexbox/flexbox-ignore-container-firstLetter.html TEST=fast/css-grid-layout/grid-container-ignore-first-letter.html BUG=430099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184858

Patch Set 1 #

Patch Set 2 : New version fixing issues with ::before pseudo-element #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M LayoutTests/css3/flexbox/flexbox-ignore-container-firstLetter.html View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M LayoutTests/css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-container-ignore-first-letter.html View 2 chunks +27 lines, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-container-ignore-first-letter-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
6 years, 1 month ago (2014-11-04 21:45:58 UTC) #2
leviw_travelin_and_unemployed
Please add a link to the text in the spec you quoted in your description. ...
6 years, 1 month ago (2014-11-05 06:55:36 UTC) #4
Manuel Rego
Thanks for the review. I've just added the links in the description. https://codereview.chromium.org/686173006/diff/20001/LayoutTests/css3/flexbox/flexbox-ignore-container-firstLetter.html File LayoutTests/css3/flexbox/flexbox-ignore-container-firstLetter.html ...
6 years, 1 month ago (2014-11-05 08:13:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686173006/40001
6 years, 1 month ago (2014-11-05 08:13:44 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 09:16:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184858

Powered by Google App Engine
This is Rietveld 408576698