Reject push registrations when no sender Id has been provided.

Reject push registrations when no sender Id has been provided.

We require this because of the underlying GCM implementation. The sender Id
can be provided through a manifest (which the browser tests uses already). Make
sure that the registration request is rejected with a descriptive error if
none has been provided.

BUG=428277
Committed: https://crrev.com/aeeaf1b32fe3c04bc8a62c6f046158a6984f89ef
Cr-Commit-Position: refs/heads/master@{#301942}

[Peter Beverloo, 2014-10-29 13:42:29]

peter@chromium.org changed reviewers:
+ fgorski@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2014-10-29 13:42:29]

+mvanouwerkerk for Push
+fgorski for OWNERS

[Michael van Ouwerkerk, 2014-10-29 13:53:18]

Thanks Peter! lgtm with nits

https://codereview.chromium.org/686133003/diff/1/chrome/test/data/push_messag...
File chrome/test/data/push_messaging/test.html (right):

https://codereview.chromium.org/686133003/diff/1/chrome/test/data/push_messag...
chrome/test/data/push_messaging/test.html:62: sendResultToTest('ok');
Please be more specific, it's harder to debug when all responses are ok/fail.
See the other functions.

https://codereview.chromium.org/686133003/diff/1/content/public/common/push_m...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/686133003/diff/1/content/public/common/push_m...
content/public/common/push_messaging_status.h:31: // Registration failed because
no sender Id was provided by the page.
nit: s/Id/id/

[Peter Beverloo, 2014-10-29 13:56:23]

peter@chromium.org changed reviewers:
+ jam@chromium.org

[Peter Beverloo, 2014-10-29 13:56:24]

Done. Thanks Michael!

+jam for content/ stamp.

https://codereview.chromium.org/686133003/diff/1/chrome/test/data/push_messag...
File chrome/test/data/push_messaging/test.html (right):

https://codereview.chromium.org/686133003/diff/1/chrome/test/data/push_messag...
chrome/test/data/push_messaging/test.html:62: sendResultToTest('ok');
On 2014/10/29 13:53:18, Michael van Ouwerkerk wrote:
> Please be more specific, it's harder to debug when all responses are ok/fail.
> See the other functions.

Done.

https://codereview.chromium.org/686133003/diff/1/content/public/common/push_m...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/686133003/diff/1/content/public/common/push_m...
content/public/common/push_messaging_status.h:31: // Registration failed because
no sender Id was provided by the page.
On 2014/10/29 13:53:18, Michael van Ouwerkerk wrote:
> nit: s/Id/id/

Done.

[fgorski, 2014-10-29 16:04:18]

gcm lgtm

[jam, 2014-10-29 20:06:26]

jam@chromium.org changed reviewers:
+ avi@chromium.org
- jam@chromium.org

[jam, 2014-10-29 20:06:27]

rerouting to Avi

[Avi (use Gerrit), 2014-10-29 20:26:56]

lgtm

stamp

[Peter Beverloo, 2014-10-29 20:45:42]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-10-29 20:47:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686133003/20001

[commit-bot: I haz the power, 2014-10-29 21:47:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-29 21:48:27]

Patchset 2 (id:??) landed as
https://crrev.com/aeeaf1b32fe3c04bc8a62c6f046158a6984f89ef
Cr-Commit-Position: refs/heads/master@{#301942}