Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 686113004: Make non-solid-color ContentLayerClient produce no solid color quads. (Closed)

Created:
6 years, 1 month ago by danakj
Modified:
6 years, 1 month ago
Reviewers:
ajuma, vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, sohanjg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make non-solid-color ContentLayerClient produce no solid color quads. Tests that want to be not solid color do so because they want to use resources for their quads. Make the FakeContentLayerClient cause every tile to use resources instead of just tiles across the center of the layer. R=ajuma, enne, vmpstr BUG=427423 Committed: https://crrev.com/8f644e8dd66293e1cf2491a9d3164ee6fdd4adaa Cr-Commit-Position: refs/heads/master@{#302865}

Patch Set 1 #

Patch Set 2 : solidcolor: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M cc/test/fake_content_layer_client.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danakj
6 years, 1 month ago (2014-11-05 15:57:16 UTC) #1
ajuma
lgtm
6 years, 1 month ago (2014-11-05 17:18:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686113004/20001
6 years, 1 month ago (2014-11-05 19:45:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 21:10:17 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 21:10:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f644e8dd66293e1cf2491a9d3164ee6fdd4adaa
Cr-Commit-Position: refs/heads/master@{#302865}

Powered by Google App Engine
This is Rietveld 408576698