Issue 686103003: Remove extraneous null-check found by findbugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686103003: Remove extraneous null-check found by findbugs. (Closed)

Created:
6 years, 1 month ago by Aaron Boodman

Modified:
6 years, 1 month ago

Reviewers:
jamesr, qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove extraneous null-check found by findbugs. This stupid thing blocks the roll Chromium-side. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/58044b38c9e52bf6df2d32e0d063c9529021e3ce

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Aaron Boodman

6 years, 1 month ago (2014-10-31 18:31:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
58044b38c9e52bf6df2d32e0d063c9529021e3ce (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages