mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java - Issue 686103003: Remove extraneous null-check found by findbugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

Issue 686103003: Remove extraneous null-check found by findbugs. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

index bbd3f068d5814d49c9f6d3453341c19555c28fa3..01cddc4880aaa6042826ae4c6d69173b118d44cf 100644

--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

+++ b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

@@ -117,9 +117,7 @@ public class BindingsHelper {

return true;

}

if (o1 == null) {

- if (o2 != null) {

- return false;

- }

+ return false;

}

return o1.equals(o2);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »