Issue 685993006: Explicitly set the observer to null in the dtor of MediaStreamRemoteVideoSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 685993006: Explicitly set the observer to null in the dtor of MediaStreamRemoteVideoSource. (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme

Modified:
6 years, 1 month ago

Reviewers:
perkj_chrome

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Explicitly set the observer to null in the dtor of MediaStreamRemoteVideoSource. This is to clear the observer pointer prior to invalidating the weak factory. BUG=369796 TBR=perkj Committed: https://crrev.com/792d2bc8ebc6e0a42b841245dbb48b2534cd6e5d Cr-Commit-Position: refs/heads/master@{#302472}

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/renderer/media/webrtc/media_stream_remote_video_source.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

Committed patchset #1 (id:1) to pending queue manually as fe125be0308e55148b669edc61eff9a89c006ea1 (presubmit successful).

6 years, 1 month ago (2014-11-03 20:27:52 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 20:28:32 UTC) #3

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/792d2bc8ebc6e0a42b841245dbb48b2534cd6e5d
Cr-Commit-Position: refs/heads/master@{#302472}

Expand Messages | Collapse Messages