content/renderer/media/webrtc/media_stream_remote_video_source.cc - Issue 685993006: Explicitly set the observer to null in the dtor of MediaStreamRemoteVideoSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source.cc

Issue 685993006: Explicitly set the observer to null in the dtor of MediaStreamRemoteVideoSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc/media_stream_remote_video_source.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source.cc b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

index c74fb52a32eb94bc86d511c4b0bc70e332202bb9..3e5f6a423d86e9eea534b2d367cb6d02a996d314 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

@@ -197,6 +197,7 @@ MediaStreamRemoteVideoSource::MediaStreamRemoteVideoSource(

MediaStreamRemoteVideoSource::~MediaStreamRemoteVideoSource() {

DCHECK(CalledOnValidThread());

+ observer_ = nullptr;

}

void MediaStreamRemoteVideoSource::GetCurrentSupportedFormats(

« no previous file with comments | « no previous file | no next file » | no next file with comments »