Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: pkg/analyzer/lib/src/generated/source.dart

Issue 685993004: Clean up logging uses (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/sdk_io.dart ('k') | pkg/analyzer/lib/src/generated/source_io.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/source.dart
diff --git a/pkg/analyzer/lib/src/generated/source.dart b/pkg/analyzer/lib/src/generated/source.dart
index 3b3d79ba61b8e8d8cf98a0e92536de17a4114163..aada0ad23d617032e0c14205568756940cc6c386 100644
--- a/pkg/analyzer/lib/src/generated/source.dart
+++ b/pkg/analyzer/lib/src/generated/source.dart
@@ -521,8 +521,10 @@ class SourceFactory {
if (uri.isAbsolute) {
return _internalResolveUri(null, uri);
}
- } catch (exception) {
- AnalysisEngine.instance.logger.logError2("Could not resolve URI: $absoluteUri", exception);
+ } catch (exception, stackTrace) {
+ AnalysisEngine.instance.logger.logError(
+ "Could not resolve URI: $absoluteUri",
+ new CaughtException(exception, stackTrace));
}
return null;
}
@@ -539,7 +541,9 @@ class SourceFactory {
try {
return _internalResolveUri(null, absoluteUri);
} on AnalysisException catch (exception, stackTrace) {
- AnalysisEngine.instance.logger.logError2("Could not resolve URI: $absoluteUri", new CaughtException(exception, stackTrace));
+ AnalysisEngine.instance.logger.logError(
+ "Could not resolve URI: $absoluteUri",
+ new CaughtException(exception, stackTrace));
}
}
return null;
@@ -603,8 +607,10 @@ class SourceFactory {
try {
// Force the creation of an escaped URI to deal with spaces, etc.
return _internalResolveUri(containingSource, parseUriWithException(containedUri));
- } catch (exception) {
- AnalysisEngine.instance.logger.logError2("Could not resolve URI ($containedUri) relative to source (${containingSource.fullName})", exception);
+ } catch (exception, stackTrace) {
+ AnalysisEngine.instance.logger.logError(
+ "Could not resolve URI ($containedUri) relative to source (${containingSource.fullName})",
+ new CaughtException(exception, stackTrace));
return null;
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/sdk_io.dart ('k') | pkg/analyzer/lib/src/generated/source_io.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698