Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: pkg/analyzer/lib/src/generated/sdk_io.dart

Issue 685993004: Clean up logging uses (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/lib/src/generated/source.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/sdk_io.dart
diff --git a/pkg/analyzer/lib/src/generated/sdk_io.dart b/pkg/analyzer/lib/src/generated/sdk_io.dart
index 920dccc4d31ac355f8ad83fe9abd23c9ec17edb4..565f080fc768ac5a6b19b83400760c7c92e9196d 100644
--- a/pkg/analyzer/lib/src/generated/sdk_io.dart
+++ b/pkg/analyzer/lib/src/generated/sdk_io.dart
@@ -7,6 +7,8 @@
library engine.sdk.io;
+import 'package:analyzer/src/generated/java_engine.dart';
+
import 'java_core.dart';
import 'java_io.dart';
import 'java_engine_io.dart';
@@ -253,8 +255,10 @@ class DirectoryBasedDartSdk implements DartSdk {
String path = library.shortName;
try {
return new FileBasedSource.con2(parseUriWithException(path), file);
- } on URISyntaxException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Failed to create URI: $path", exception);
+ } on URISyntaxException catch (exception, stackTrace) {
+ AnalysisEngine.instance.logger.logInformation(
+ "Failed to create URI: $path",
+ new CaughtException(exception, stackTrace));
return null;
}
}
@@ -263,8 +267,10 @@ class DirectoryBasedDartSdk implements DartSdk {
String path = "${library.shortName}/${filePath.substring(libraryPath.length + 1)}";
try {
return new FileBasedSource.con2(parseUriWithException(path), file);
- } on URISyntaxException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Failed to create URI: $path", exception);
+ } on URISyntaxException catch (exception, stackTrace) {
+ AnalysisEngine.instance.logger.logInformation(
+ "Failed to create URI: $path",
+ new CaughtException(exception, stackTrace));
return null;
}
}
@@ -497,8 +503,10 @@ class DirectoryBasedDartSdk implements DartSdk {
try {
String contents = librariesFile.readAsStringSync();
return new SdkLibrariesReader(useDart2jsPaths).readFromFile(librariesFile, contents);
- } catch (exception) {
- AnalysisEngine.instance.logger.logError2("Could not initialize the library map from ${librariesFile.getAbsolutePath()}", exception);
+ } catch (exception, stackTrace) {
+ AnalysisEngine.instance.logger.logError(
+ "Could not initialize the library map from ${librariesFile.getAbsolutePath()}",
+ new CaughtException(exception, stackTrace));
return new LibraryMap();
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/lib/src/generated/source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698