Issue 685983002: Remove Nine Patch layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 685983002: Remove Nine Patch layers. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove Nine Patch layers. These were only used for doing effects in Clank and the shadows around the page when bouncing on the Mac. Now they're dead code. In the future if we decide nine patch is an API we really want we should expose web platform primitives instead of having a special API on layer. R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5943d39b7425ce2aada8635b7661674a5df1f9b2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -184 lines)			Patch
M	sky/engine/platform/graphics/GraphicsLayer.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/platform/graphics/GraphicsLayer.cpp	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	sky/engine/public/platform/WebCompositorSupport.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	sky/engine/public/platform/WebNinePatchLayer.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	sky/viewer/cc/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/viewer/cc/web_compositor_support_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/viewer/cc/web_compositor_support_impl.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download
D	sky/viewer/cc/web_nine_patch_layer_impl.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	sky/viewer/cc/web_nine_patch_layer_impl.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

6 years, 1 month ago (2014-10-29 03:13:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5943d39b7425ce2aada8635b7661674a5df1f9b2.