Source/core/rendering/RenderInline.cpp - Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderInline.cpp

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderInline.cpp

diff --git a/Source/core/rendering/RenderInline.cpp b/Source/core/rendering/RenderInline.cpp

index d156b0b6a073128e62648eef28c4461f2a99b5ec..7d433dce0cb63c9d8ee1c0d89d21bcad997f6035 100644

--- a/Source/core/rendering/RenderInline.cpp

+++ b/Source/core/rendering/RenderInline.cpp

@@ -804,7 +804,7 @@ private:

bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset)

{

- ASSERT(result.isRectBasedTest() && !alwaysCreateLineBoxes());

+ ASSERT(!alwaysCreateLineBoxes());

if (!visibleToHitTestRequest(request))

return false;

« LayoutTests/fast/events/hit-test-culled_inline-expected.txt ('K') | « Source/core/rendering/InlineFlowBox.cpp ('k') | no next file » | no next file with comments »