Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: Source/core/rendering/RenderInline.cpp

Issue 685963002: We need to account for culled inline parents of the hit-tested nodes.(Reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 private: 797 private:
798 bool m_intersected; 798 bool m_intersected;
799 Region& m_region; 799 Region& m_region;
800 const HitTestLocation& m_location; 800 const HitTestLocation& m_location;
801 }; 801 };
802 802
803 } // unnamed namespace 803 } // unnamed namespace
804 804
805 bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestRes ult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accu mulatedOffset) 805 bool RenderInline::hitTestCulledInline(const HitTestRequest& request, HitTestRes ult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accu mulatedOffset)
806 { 806 {
807 ASSERT(result.isRectBasedTest() && !alwaysCreateLineBoxes()); 807 ASSERT(!alwaysCreateLineBoxes());
808 if (!visibleToHitTestRequest(request)) 808 if (!visibleToHitTestRequest(request))
809 return false; 809 return false;
810 810
811 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset)); 811 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset));
812 812
813 Region regionResult; 813 Region regionResult;
814 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation); 814 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation);
815 generateCulledLineBoxRects(context, this); 815 generateCulledLineBoxRects(context, this);
816 816
817 if (context.intersected()) { 817 if (context.intersected()) {
(...skipping 592 matching lines...) Expand 10 before | Expand all | Expand 10 after
1410 container = this; 1410 container = this;
1411 1411
1412 FloatPoint absPos = container->localToAbsolute(); 1412 FloatPoint absPos = container->localToAbsolute();
1413 region.bounds.setX(absPos.x() + region.bounds.x()); 1413 region.bounds.setX(absPos.x() + region.bounds.x());
1414 region.bounds.setY(absPos.y() + region.bounds.y()); 1414 region.bounds.setY(absPos.y() + region.bounds.y());
1415 1415
1416 regions.append(region); 1416 regions.append(region);
1417 } 1417 }
1418 1418
1419 } // namespace blink 1419 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698