Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 685723002: [turbofan] LoadElement should not have a control input. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] LoadElement should not have a control input. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -39 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-10-28 12:44:53 UTC) #1
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-10-28 12:45:23 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-10-28 12:59:53 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-10-28 13:00:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698