Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/compiler/operator-properties-inl.h

Issue 685723002: [turbofan] LoadElement should not have a control input. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_OPERATOR_PROPERTIES_INL_H_ 5 #ifndef V8_COMPILER_OPERATOR_PROPERTIES_INL_H_
6 #define V8_COMPILER_OPERATOR_PROPERTIES_INL_H_ 6 #define V8_COMPILER_OPERATOR_PROPERTIES_INL_H_
7 7
8 #include "src/compiler/common-operator.h" 8 #include "src/compiler/common-operator.h"
9 #include "src/compiler/js-operator.h" 9 #include "src/compiler/js-operator.h"
10 #include "src/compiler/linkage.h" 10 #include "src/compiler/linkage.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 return 0; // no effects. 115 return 0; // no effects.
116 return 1; 116 return 1;
117 } 117 }
118 118
119 inline int OperatorProperties::GetControlInputCount(const Operator* op) { 119 inline int OperatorProperties::GetControlInputCount(const Operator* op) {
120 // TODO(titzer): fix this mess; just make them a count on the operator. 120 // TODO(titzer): fix this mess; just make them a count on the operator.
121 switch (op->opcode()) { 121 switch (op->opcode()) {
122 case IrOpcode::kPhi: 122 case IrOpcode::kPhi:
123 case IrOpcode::kEffectPhi: 123 case IrOpcode::kEffectPhi:
124 case IrOpcode::kLoad: 124 case IrOpcode::kLoad:
125 case IrOpcode::kLoadElement:
126 case IrOpcode::kLoadField: 125 case IrOpcode::kLoadField:
127 return 1; 126 return 1;
128 #define OPCODE_CASE(x) case IrOpcode::k##x: 127 #define OPCODE_CASE(x) case IrOpcode::k##x:
129 CONTROL_OP_LIST(OPCODE_CASE) 128 CONTROL_OP_LIST(OPCODE_CASE)
130 #undef OPCODE_CASE 129 #undef OPCODE_CASE
131 if (op->opcode() == IrOpcode::kBranch) return 1; 130 if (op->opcode() == IrOpcode::kBranch) return 1;
132 if (op->opcode() == IrOpcode::kTerminate) return 1; 131 if (op->opcode() == IrOpcode::kTerminate) return 1;
133 // Control operators are Operator1<int>. 132 // Control operators are Operator1<int>.
134 return OpParameter<int>(op); 133 return OpParameter<int>(op);
135 default: 134 default:
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 opcode == IrOpcode::kDead || opcode == IrOpcode::kLoop || 188 opcode == IrOpcode::kDead || opcode == IrOpcode::kLoop ||
190 opcode == IrOpcode::kMerge || opcode == IrOpcode::kIfTrue || 189 opcode == IrOpcode::kMerge || opcode == IrOpcode::kIfTrue ||
191 opcode == IrOpcode::kIfFalse; 190 opcode == IrOpcode::kIfFalse;
192 } 191 }
193 192
194 } // namespace compiler 193 } // namespace compiler
195 } // namespace internal 194 } // namespace internal
196 } // namespace v8 195 } // namespace v8
197 196
198 #endif // V8_COMPILER_OPERATOR_PROPERTIES_INL_H_ 197 #endif // V8_COMPILER_OPERATOR_PROPERTIES_INL_H_
OLDNEW
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698