Issue 685593005: Remove concept of child Widgets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 685593005: Remove concept of child Widgets. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove concept of child Widgets. FrameView doesn't really need to know about the child widgets, which are just Scrollbars now. I also deleted some dead code from Widget and removed FrameWidget since we don't need that abstraction now. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/756449f50bc19c5e82d9f47ff90dfc5e89f59fb6

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -93 lines)			Patch
M	sky/engine/core/dom/Document.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.h	View	5 chunks	+1 line, -8 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	4 chunks	+0 lines, -28 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerScrollableArea.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	sky/engine/platform/FrameWidget.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	sky/engine/platform/Widget.h	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	sky/engine/platform/scroll/Scrollbar.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/platform/scroll/Scrollbar.cpp	View	2 chunks	+0 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

esprehn

6 years, 1 month ago (2014-10-28 23:53:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
756449f50bc19c5e82d9f47ff90dfc5e89f59fb6.