chrome/browser/safe_browsing/download_feedback_unittest.cc - Issue 685553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback_unittest.cc

Issue 685553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_feedback_service_unittest.cc ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_feedback_unittest.cc b/chrome/browser/safe_browsing/download_feedback_unittest.cc

index fa9113a9b96e917394e73aa286b0cc01ac798277..f4fe38ad0ffbea2aa45e36b2965cdcb0a3f650cf 100644

--- a/chrome/browser/safe_browsing/download_feedback_unittest.cc

+++ b/chrome/browser/safe_browsing/download_feedback_unittest.cc

@@ -110,7 +110,7 @@ class DownloadFeedbackTest : public testing::Test {

EXPECT_NE(io_task_runner_, file_task_runner_);

}

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

upload_file_path_ = temp_dir_.path().AppendASCII("test file");

upload_file_data_ = "data";

@@ -120,9 +120,7 @@ class DownloadFeedbackTest : public testing::Test {

TwoPhaseUploader::RegisterFactory(&two_phase_uploader_factory_);

}

- virtual void TearDown() override {

- TwoPhaseUploader::RegisterFactory(NULL);

- }

+ void TearDown() override { TwoPhaseUploader::RegisterFactory(NULL); }

FakeUploader* uploader() const {

return two_phase_uploader_factory_.uploader_;