extensions/browser/guest_view/web_view/web_view_apitest.h - Issue 685503002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.h

Issue 685503002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/guest_view_manager_unittest.cc ('k') | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_apitest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.h b/extensions/browser/guest_view/web_view/web_view_apitest.h

index 0c27136ec968a7f4933f71b32f5a051e3c10568a..06ed26a1e93eea0a40319ee23fca7944376761ee 100644

--- a/extensions/browser/guest_view/web_view/web_view_apitest.h

+++ b/extensions/browser/guest_view/web_view/web_view_apitest.h

@@ -41,10 +41,10 @@ class WebViewAPITest : public AppShellTest {

void SendMessageToEmbedder(const std::string& message);

// content::BrowserTestBase implementation.

- virtual void RunTestOnMainThreadLoop() override;

- virtual void SetUpCommandLine(base::CommandLine* command_line) override;

- virtual void SetUpOnMainThread() override;

- virtual void TearDownOnMainThread() override;

+ void RunTestOnMainThreadLoop() override;

+ void SetUpCommandLine(base::CommandLine* command_line) override;

+ void SetUpOnMainThread() override;

+ void TearDownOnMainThread() override;

content::WebContents* embedder_web_contents_;

TestGuestViewManagerFactory factory_;

@@ -56,7 +56,7 @@ class WebViewAPITest : public AppShellTest {

class WebViewDPIAPITest : public WebViewAPITest {

protected:

- virtual void SetUp() override;

+ void SetUp() override;

static float scale() { return 2.0f; }

};