extensions/browser/guest_view/web_view/web_view_apitest.cc - Issue 685503002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 685503002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_apitest.h ('k') | extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_apitest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc

index 574e3349b49a8f376a5ec86be9d1c36a6c254cac..76de4d63929f74468ebea9f3cd8ce88e2cd18a9b 100644

--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc

@@ -45,9 +45,7 @@ const char kTestWebSocketPort[] = "testWebSocketPort";

class EmptyHttpResponse : public net::test_server::HttpResponse {

public:

- virtual std::string ToResponseString() const override {

- return std::string();

- }

+ std::string ToResponseString() const override { return std::string(); }

};

// Handles |request| by serving a redirect response if the |User-Agent| is

@@ -82,7 +80,7 @@ class WebContentsHiddenObserver : public content::WebContentsObserver {

}

// WebContentsObserver.

- virtual void WasHidden() override {

+ void WasHidden() override {

hidden_observed_ = true;

hidden_callback_.Run();

}