Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 6853008: Revert GCC compilation fix on 3.1 branch that contained an invalid (Closed)

Created:
9 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Revert GCC compilation fix on 3.1 branch that contained an invalid change to the x64 classic codegen. On the 3.1 branch, register r12 is not reserved. Committed: http://code.google.com/p/v8/source/detail?r=7610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/v8globals.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 8 months ago (2011-04-14 07:30:39 UTC) #1
Rico
9 years, 8 months ago (2011-04-14 07:31:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698