Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 685243002: allow SkUserConfig.h to control NOGPU (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

allow SkUserConfig.h to control NOGPU BUG=skia: Committed: https://skia.googlesource.com/skia/+/f037e0bf138a4e842f39e19864d05010a54950c9

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M gm/discard.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685243002/40001
6 years, 1 month ago (2014-10-30 12:59:05 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 12:59:06 UTC) #3
reed1
ptal -- will remove SkPostConfig.h when ready to submit
6 years, 1 month ago (2014-10-30 13:00:23 UTC) #6
robertphillips
lgtm l
6 years, 1 month ago (2014-10-30 13:09:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685243002/60001
6 years, 1 month ago (2014-10-30 13:33:16 UTC) #9
bsalomon
https://codereview.chromium.org/685243002/diff/40001/include/core/SkPostConfig.h File include/core/SkPostConfig.h (right): https://codereview.chromium.org/685243002/diff/40001/include/core/SkPostConfig.h#newcode71 include/core/SkPostConfig.h:71: #undef SK_SUPPORT_GPU ?
6 years, 1 month ago (2014-10-30 13:33:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/359)
6 years, 1 month ago (2014-10-30 13:34:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685243002/80001
6 years, 1 month ago (2014-10-30 13:42:36 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:34:21 UTC) #15
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as f037e0bf138a4e842f39e19864d05010a54950c9

Powered by Google App Engine
This is Rietveld 408576698