Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 68523014: Update remaining NodeTraversal / ElementTraversal methods to take references (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update remaining NodeTraversal / ElementTraversal methods to take references Update remaining NodeTraversal / ElementTraversal methods to take references in argument instead of pointers as their implementation assumes the pointers are non-null. This makes the code look safer. As a side effect, RenderCounter API was also updated to use more references. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162040

Patch Set 1 #

Patch Set 2 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -110 lines) Patch
M Source/core/dom/ElementTraversal.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeTraversal.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/NodeTraversal.cpp View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/core/dom/Text.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/CounterNode.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/CounterNode.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderCounter.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 24 chunks +60 lines, -63 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
7 years, 1 month ago (2013-11-14 15:44:11 UTC) #1
adamk
lgtm
7 years, 1 month ago (2013-11-14 17:54:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/68523014/30001
7 years, 1 month ago (2013-11-14 17:55:42 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 18:53:31 UTC) #4
Message was sent while issue was closed.
Change committed as 162040

Powered by Google App Engine
This is Rietveld 408576698