Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 685203004: A few fixes to make Windows Mojo build work. (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M base/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/tools/mojob.py View 3 chunks +9 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
jam
The first three files are a merge from your chromium cl https://codereview.chromium.org/709793002
6 years, 1 month ago (2014-11-08 03:16:51 UTC) #2
scottmg
lgtm https://codereview.chromium.org/685203004/diff/1/mojo/tools/mojob.py File mojo/tools/mojob.py (right): https://codereview.chromium.org/685203004/diff/1/mojo/tools/mojob.py#newcode64 mojo/tools/mojob.py:64: if you add if platform.system() == 'Windows' and ...
6 years, 1 month ago (2014-11-08 03:22:27 UTC) #3
jam
https://codereview.chromium.org/685203004/diff/1/mojo/tools/mojob.py File mojo/tools/mojob.py (right): https://codereview.chromium.org/685203004/diff/1/mojo/tools/mojob.py#newcode64 mojo/tools/mojob.py:64: On 2014/11/08 03:22:27, scottmg wrote: > if you add ...
6 years, 1 month ago (2014-11-08 03:23:51 UTC) #4
scottmg
sgtm (I couldn't get mojob.py to run locally, but that was probably because of the ...
6 years, 1 month ago (2014-11-08 03:25:17 UTC) #5
scottmg
On 2014/11/08 03:25:17, scottmg wrote: > sgtm (I couldn't get mojob.py to run locally, but ...
6 years, 1 month ago (2014-11-08 03:25:34 UTC) #6
jam
6 years, 1 month ago (2014-11-08 03:27:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
726443c943af9eda16621199a9d2144c42984bbb.

Powered by Google App Engine
This is Rietveld 408576698