Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709793002: gn win: disable 4267 (need for win x64) (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
brettw, jam
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn win: disable 4267 (need for win x64) (backported from mojo) R=jam@chromium.org Committed: https://crrev.com/af5a5768de0ef5563228a0a8c0dd519c92c12a86 Cr-Commit-Position: refs/heads/master@{#303341}

Patch Set 1 #

Patch Set 2 : u18n #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M base/BUILD.gn View 1 2 chunks +6 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
scottmg
6 years, 1 month ago (2014-11-07 19:18:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709793002/40001
6 years, 1 month ago (2014-11-07 19:51:10 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-07 19:51:12 UTC) #5
jam
lgtm
6 years, 1 month ago (2014-11-07 23:24:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709793002/50002
6 years, 1 month ago (2014-11-07 23:33:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22986)
6 years, 1 month ago (2014-11-07 23:40:21 UTC) #10
scottmg
+brettw owners
6 years, 1 month ago (2014-11-07 23:43:08 UTC) #12
brettw
lgtm
6 years, 1 month ago (2014-11-08 00:09:03 UTC) #13
brettw
lgtm lgtm
6 years, 1 month ago (2014-11-08 00:09:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709793002/50002
6 years, 1 month ago (2014-11-08 00:14:52 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:50002)
6 years, 1 month ago (2014-11-08 00:39:54 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 00:40:41 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/af5a5768de0ef5563228a0a8c0dd519c92c12a86
Cr-Commit-Position: refs/heads/master@{#303341}

Powered by Google App Engine
This is Rietveld 408576698