Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 685113003: Enable distance field path rendering in Chrome. (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Enable distance field path rendering in Chrome. - Add stat tracking for df-renderable paths - Modify GPU rasterization veto to account for df-renderable paths - Remove #define hiding df paths from Chromium and Android BUG=skia:2935 Committed: https://skia.googlesource.com/skia/+/f7007b023d03de0693a39cba45ecdcc63eb9950d

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPicture.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 1 2 7 chunks +13 lines, -4 lines 0 comments Download
M src/core/SkPictureContentInfo.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPictureContentInfo.cpp View 1 6 chunks +10 lines, -2 lines 0 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jvanverth1
Still need to add volatile flag to Canvas2D paths before this can go in, but ...
6 years, 1 month ago (2014-10-29 20:33:32 UTC) #2
bsalomon
https://codereview.chromium.org/685113003/diff/1/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/685113003/diff/1/src/core/SkPicture.cpp#newcode182 src/core/SkPicture.cpp:182: pathBounds.height() < 64.f) { && !op.path.isVolatile() ? https://codereview.chromium.org/685113003/diff/1/src/core/SkPictureContentInfo.cpp File ...
6 years, 1 month ago (2014-10-29 20:53:45 UTC) #3
bsalomon
On 2014/10/29 20:53:45, bsalomon wrote: > https://codereview.chromium.org/685113003/diff/1/src/core/SkPicture.cpp > File src/core/SkPicture.cpp (right): > > https://codereview.chromium.org/685113003/diff/1/src/core/SkPicture.cpp#newcode182 > ...
6 years, 1 month ago (2014-10-29 21:02:09 UTC) #4
jvanverth1
https://codereview.chromium.org/685113003/diff/1/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/685113003/diff/1/src/core/SkPicture.cpp#newcode182 src/core/SkPicture.cpp:182: pathBounds.height() < 64.f) { On 2014/10/29 20:53:45, bsalomon wrote: ...
6 years, 1 month ago (2014-10-30 18:55:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685113003/20001
6 years, 1 month ago (2014-11-04 15:40:11 UTC) #7
commit-bot: I haz the power
Failed to apply patch for gyp/skia_for_chromium_defines.gypi: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-11-04 15:40:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/685113003/40001
6 years, 1 month ago (2014-11-04 15:49:12 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 15:59:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as f7007b023d03de0693a39cba45ecdcc63eb9950d

Powered by Google App Engine
This is Rietveld 408576698