Support style invalidation for ::cue selectors.

Source/core/css/RuleFeature.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 120 matching lines @@
     case CSSSelector::PseudoEnd:
     case CSSSelector::PseudoDoubleButton:
     case CSSSelector::PseudoSingleButton:
     case CSSSelector::PseudoNoButton:
     case CSSSelector::PseudoFullScreen:
     case CSSSelector::PseudoFullScreenDocument:
     case CSSSelector::PseudoFullScreenAncestor:
     case CSSSelector::PseudoInRange:
     case CSSSelector::PseudoOutOfRange:
     case CSSSelector::PseudoWebKitCustomElement:
+    case CSSSelector::PseudoCue:
+    case CSSSelector::PseudoFutureCue:
+    case CSSSelector::PseudoPastCue:
     case CSSSelector::PseudoUnresolved:
     case CSSSelector::PseudoContent:
     case CSSSelector::PseudoHost:
     case CSSSelector::PseudoShadow:
     case CSSSelector::PseudoListBox:
         return true;
     case CSSSelector::PseudoNotParsed:
     case CSSSelector::PseudoUnknown:
     case CSSSelector::PseudoLeftPage:
     case CSSSelector::PseudoRightPage:
@@ skipping 13 matching lines @@
 static bool requiresSubtreeInvalidation(const CSSSelector& selector)
 {
     if (!selector.matchesPseudoElement() && selector.match() != CSSSelector::PseudoClass) {
         ASSERT(supportsInvalidation(selector.match()));
         return false;
     }
 
     switch (selector.pseudoType()) {
     case CSSSelector::PseudoFirstLine:
     case CSSSelector::PseudoFirstLetter:
-    case CSSSelector::PseudoCue:
-    case CSSSelector::PseudoFutureCue:
-    case CSSSelector::PseudoPastCue:
     case CSSSelector::PseudoSpatialNavigationFocus:
         // FIXME: Most pseudo classes/elements above can be supported and moved
         // to assertSupportedPseudo(). Move on a case-by-case basis. If they
         // require subtree invalidation, document why.
     case CSSSelector::PseudoHostContext:
         // :host-context matches a shadow host, yet the simple selectors inside
         // :host-context matches an ancestor of the shadow host.
         return true;
     default:
         ASSERT(supportsInvalidation(selector.pseudoType()));
@@ skipping 22 matching lines @@
 
         if (component->match() == CSSSelector::Class || component->match() == CSSSelector::Id
             || (component->match() == CSSSelector::Tag && component->tagQName().localName() != starAtom)
             || component->isAttributeSelector() || component->isCustomPseudoElement()) {
             if (!foundCombinator) {
                 // We have found an invalidation set feature in the rightmost compound selector.
                 foundIdent = true;
             }
         } else if (component->pseudoType() == CSSSelector::PseudoNot
             || component->pseudoType() == CSSSelector::PseudoHost
-            || component->pseudoType() == CSSSelector::PseudoAny) {
+            || component->pseudoType() == CSSSelector::PseudoAny
+            || component->pseudoType() == CSSSelector::PseudoCue) {
             if (const CSSSelectorList* selectorList = component->selectorList()) {
                 // Features inside :not() are not added to the feature set, so consider it a universal selector.
                 bool foundUniversal = component->pseudoType() == CSSSelector::PseudoNot;
                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector)) {
                     // Find the invalidation set mode for each of the selectors in the selector list
                     // of a :not(), :host(), etc. For instance, ".x :-webkit-any(.a, .b)" yields an
                     // AddFeatures mode for both ".a" and ".b". ":-webkit-any(.a, *)" yields AddFeatures
                     // for ".a", but UseSubtreeStyleChange for "*". One sub-selector without invalidation
                     // set features is sufficient to cause the selector to be a universal selector as far
                     // the invalidation set is concerned.
@@ skipping 106 matching lines @@
     return AddFeatures;
 }
 
 const CSSSelector* RuleFeatureSet::extractInvalidationSetFeatures(const CSSSelector& selector, InvalidationSetFeatures& features, bool negated)
 {
     for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
         if (!negated)
             extractInvalidationSetFeature(*current, features);
         // Initialize the entry in the invalidation set map, if supported.
         invalidationSetForSelector(*current);
-        if (current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny || current->pseudoType() == CSSSelector::PseudoNot) {
+        if (current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny || current->pseudoType() == CSSSelector::PseudoNot || current->pseudoType() == CSSSelector::PseudoCue) {
             if (const CSSSelectorList* selectorList = current->selectorList()) {
                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
                     extractInvalidationSetFeatures(*selector, features, current->pseudoType() == CSSSelector::PseudoNot);
             }
         }
 
         if (current->relation() == CSSSelector::SubSelector)
             continue;
 
         features.treeBoundaryCrossing = current->isShadowSelector();
@@ skipping 41 matching lines @@
 {
     for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
         if (DescendantInvalidationSet* invalidationSet = invalidationSetForSelector(*current)) {
             addFeaturesToInvalidationSet(*invalidationSet, features);
         } else {
             if (current->isTreeBoundaryCrossing())
                 features.treeBoundaryCrossing = true;
             if (current->isInsertionPointCrossing())
                 features.insertionPointCrossing = true;
             if (const CSSSelectorList* selectorList = current->selectorList()) {
-                ASSERT(current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny || current->pseudoType() == CSSSelector::PseudoNot);
+                ASSERT(current->pseudoType() == CSSSelector::PseudoHost || current->pseudoType() == CSSSelector::PseudoAny || current->pseudoType() == CSSSelector::PseudoNot || current->pseudoType() == CSSSelector::PseudoCue);

[chrishtr, 2014/11/12 21:36:42]

This code is repeated 3 times at line 219, 347 and 409. Factor into a helper.

                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
                     addFeaturesToInvalidationSets(*selector, features);
             }
         }
 
         if (current->relation() == CSSSelector::SubSelector)
             continue;
 
         if (current->isShadowSelector())
             features.treeBoundaryCrossing = true;
@@ skipping 233 matching lines @@
     visitor->trace(uncommonAttributeRules);
     visitor->trace(m_classInvalidationSets);
     visitor->trace(m_attributeInvalidationSets);
     visitor->trace(m_idInvalidationSets);
     visitor->trace(m_pseudoInvalidationSets);
     visitor->trace(m_styleInvalidator);
 #endif
 }
 
 } // namespace blink