Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 684653009: IDL: Fix union type support in cross-component partial interfaces (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Fix union type support in cross-component partial interfaces If a partial interface in modules extends an interface in core and uses any union types, the generated bindings/modules/v8/V8*Partial.cpp file needs to include UnionTypesModules.h. This did not happen, since use of union types was only tracked per main (non-partial) interface. BUG=240176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M Source/bindings/scripts/compute_interfaces_info_individual.py View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
PTAL This fixes the include issue I have in https://codereview.chromium.org/714123002/.
6 years, 1 month ago (2014-11-11 15:57:15 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-11 16:10:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684653009/1
6 years, 1 month ago (2014-11-11 16:12:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185136
6 years, 1 month ago (2014-11-11 17:56:35 UTC) #6
bashi
6 years, 1 month ago (2014-11-11 23:22:27 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698