Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/scripts/compute_interfaces_info_individual.py

Issue 684653009: IDL: Fix union type support in cross-component partial interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/compute_interfaces_info_individual.py
diff --git a/Source/bindings/scripts/compute_interfaces_info_individual.py b/Source/bindings/scripts/compute_interfaces_info_individual.py
index 9bfa7b6263d22a973e61bc9154354f99b85bf247..7d9f77fdc280b3edef6ec0d0bd2cd3cadae12cd3 100755
--- a/Source/bindings/scripts/compute_interfaces_info_individual.py
+++ b/Source/bindings/scripts/compute_interfaces_info_individual.py
@@ -168,11 +168,10 @@ class InterfaceInfoCollector(object):
self.union_types = set()
def add_paths_to_partials_dict(self, partial_interface_name, full_path,
- this_include_path=None):
+ include_paths):
paths_dict = self.partial_interface_files[partial_interface_name]
paths_dict['full_paths'].append(full_path)
- if this_include_path:
- paths_dict['include_paths'].append(this_include_path)
+ paths_dict['include_paths'].extend(include_paths)
def collect_info(self, idl_filename):
"""Reads an idl file and collects information which is required by the
@@ -212,7 +211,14 @@ class InterfaceInfoCollector(object):
if definition.is_partial:
# We don't create interface_info for partial interfaces, but
# adds paths to another dict.
- self.add_paths_to_partials_dict(definition.name, full_path, this_include_path)
+ partial_include_paths = []
+ if this_include_path:
+ partial_include_paths.append(this_include_path)
+ if this_union_types:
+ component = idl_filename_to_component(idl_filename)
+ partial_include_paths.append(
+ 'bindings/%s/v8/UnionTypes%s.h' % (component, component.capitalize()))
+ self.add_paths_to_partials_dict(definition.name, full_path, partial_include_paths)
return
# 'implements' statements can be included in either the file for the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698