Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684653003: Adding layout test for ArrayBufferView Posting (Closed)

Created:
6 years, 1 month ago by Paritosh Kumar
Modified:
6 years, 1 month ago
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding layout test for ArrayBufferView Posting Using POST method for sending. BUG=385455 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184565

Patch Set 1 #

Total comments: 8

Patch Set 2 : After changing from sync to async. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Paritosh Kumar
PTAL.
6 years, 1 month ago (2014-10-28 15:31:20 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/684653003/diff/1/LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html File LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html (right): https://codereview.chromium.org/684653003/diff/1/LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html#newcode3 LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html:3: <body> ok to omit them. instead add DOCTYPE please. ...
6 years, 1 month ago (2014-10-29 04:41:07 UTC) #3
Paritosh Kumar
Thanks. Updated as suggested. PTAL. https://codereview.chromium.org/684653003/diff/1/LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html File LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html (right): https://codereview.chromium.org/684653003/diff/1/LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html#newcode3 LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html:3: <body> On 2014/10/29 04:41:07, ...
6 years, 1 month ago (2014-10-29 05:08:24 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm
6 years, 1 month ago (2014-10-29 05:09:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684653003/20001
6 years, 1 month ago (2014-10-29 05:10:00 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 06:13:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184565

Powered by Google App Engine
This is Rietveld 408576698