LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html - Issue 684653003: Adding layout test for ArrayBufferView Posting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view.html

Issue 684653003: Adding layout test for ArrayBufferView Posting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head></head>

	3 <body>
	tyoshino (SeeGerritForStatus) 2014/10/29 04:41:07 ok to omit them. instead add DOCTYPE please. http ok to omit them. instead add DOCTYPE please. http://www.chromium.org/blink/coding-style/layout-test-style-guidelines Paritosh Kumar 2014/10/29 05:08:24 Done. Show quoted text On 2014/10/29 04:41:07, tyoshino wrote: > ok to omit them. instead add DOCTYPE please. > > http://www.chromium.org/blink/coding-style/layout-test-style-guidelines Done.
	4

	5 <script src="/js-test-resources/js-test.js"></script>

	6 <script>

	7 description('Test for ArrayBuffer Post in XMLHttpRequest send');
	tyoshino (SeeGerritForStatus) 2014/10/29 04:41:07 POST POST Paritosh Kumar 2014/10/29 05:08:24 Done. Show quoted text On 2014/10/29 04:41:07, tyoshino wrote: > POST Done.
	8 window.jsTestIsAsync = true;

	9

	10 new Promise(function(resolve, reject) {

	11 var array = new Uint8Array([0, 1, 2, 25, 45, 58, 255]);

	12 var xhr = new XMLHttpRequest;

	13 xhr.open("POST", "resources/post-echo-as-ascii.cgi", false);
	tyoshino (SeeGerritForStatus) 2014/10/29 04:41:07 we're moving toward deprecating sync XHR. https:// we're moving toward deprecating sync XHR. https://codereview.chromium.org/585873002/ let's use async mode. Paritosh Kumar 2014/10/29 05:08:24 Done. Show quoted text On 2014/10/29 04:41:07, tyoshino wrote: > we're moving toward deprecating sync XHR. > https://codereview.chromium.org/585873002/ > let's use async mode. Done.
	14 xhr.onreadystatechange = function() {

	15 debug('xhr.readyState = ' + xhr.readyState + ': responseURL = ' + xh r.responseURL);
	tyoshino (SeeGerritForStatus) 2014/10/29 04:41:07 if we switch to async xhr, this can be source of f if we switch to async xhr, this can be source of flakiness. onreadystatechange may be invoked multiple times in LOADING (Blink is violating the spec in this point for backward compatibility) depending on timing. unless you want to check responseURL value for each readyState, let's just put this line inside the if-clause below. or save and compare with the last readyState not to print multiple logs for the same readyState value. Paritosh Kumar 2014/10/29 05:08:24 Yes, this results in failure so shifting it in if- Yes, this results in failure so shifting it in if-clause as suggested. Thanks.
	16 if (xhr.readyState === 4) {

	17 resolve(xhr);

	18 }

	19 }

	20 xhr.send(new DataView(array.buffer));

	21 }).then(function(xhr) {

	22 window.status = xhr.status;

	23 shouldBeEqualToString('status', '200');

	24 responseText = xhr.responseText;

	25 shouldBeEqualToString('responseText', '0 1 2 25 45 58 255');

	26 }).catch(function(reason) {

	27 testFailed(String(reason));

	28 }).then(finishJSTest, finishJSTest);

	29

	30 </script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/xmlhttprequest/post-arraybuffer-data-view-expected.txt » ('j') | no next file with comments »