chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/proxy_policy_unittest.cc ('K') | « chrome/browser/prefs/tracked/pref_service_hash_store_contents_unittest.cc ('k') | chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc » ('j') | chrome/browser/prerender/prerender_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc

diff --git a/chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc b/chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc

index 693fbfcc0a6035e29ca4e478cc06d98179ad036a..27b45d77ac027c65ac569159638d6f92c4092d06 100644

--- a/chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc

+++ b/chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc

@@ -62,7 +62,7 @@ class SegregatedPrefStoreTest : public testing::Test {

read_error_delegate_(

new MockReadErrorDelegate(&read_error_delegate_data_)) {}

- virtual void SetUp() override {

+ void SetUp() override {

selected_store_ = new TestingPrefStore;

default_store_ = new TestingPrefStore;

@@ -77,9 +77,7 @@ class SegregatedPrefStoreTest : public testing::Test {

segregated_store_->AddObserver(&observer_);

}

- virtual void TearDown() override {

- segregated_store_->RemoveObserver(&observer_);

- }

+ void TearDown() override { segregated_store_->RemoveObserver(&observer_); }

James Hawkins 2014/10/28 23:04:23 Undo this pull-up.

protected:

scoped_ptr<PersistentPrefStore::ReadErrorDelegate> GetReadErrorDelegate() {