chrome/browser/prefs/proxy_policy_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/proxy_policy_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/pref_model_associator_unittest.cc ('K') | « chrome/browser/prefs/profile_pref_store_manager_unittest.cc ('k') | chrome/browser/prefs/session_startup_pref_unittest.cc » ('j') | chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/proxy_policy_unittest.cc

diff --git a/chrome/browser/prefs/proxy_policy_unittest.cc b/chrome/browser/prefs/proxy_policy_unittest.cc

index f22b3c3a5f983fef9a6a0e894025737ec5436566..7e20c33d30e755bb5ac528b7c5fd96c0e8242b8c 100644

--- a/chrome/browser/prefs/proxy_policy_unittest.cc

+++ b/chrome/browser/prefs/proxy_policy_unittest.cc

@@ -84,7 +84,7 @@ class ProxyPolicyTest : public testing::Test {

ProxyPolicyTest()

: command_line_(CommandLine::NO_PROGRAM) {}

- virtual void SetUp() override {

+ void SetUp() override {

EXPECT_CALL(provider_, IsInitializationComplete(_))

.WillRepeatedly(Return(true));

@@ -94,9 +94,7 @@ class ProxyPolicyTest : public testing::Test {

provider_.Init();

}

- virtual void TearDown() override {

- provider_.Shutdown();

- }

+ void TearDown() override { provider_.Shutdown(); }

James Hawkins 2014/10/28 23:04:23 Undo this pull-up.

scoped_ptr<PrefService> CreatePrefService(bool with_managed_policies) {

PrefServiceMockFactory factory;