components/sync_driver/device_info_sync_service_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_sync_service_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/device_info_data_type_controller_unittest.cc ('k') | components/sync_driver/generic_change_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/device_info_sync_service_unittest.cc

diff --git a/components/sync_driver/device_info_sync_service_unittest.cc b/components/sync_driver/device_info_sync_service_unittest.cc

index 9722aa4d9c94726a165b0242234b265dc58d3635..b083e12f1ba31d65db393d01e4f9bc954ff6dde8 100644

--- a/components/sync_driver/device_info_sync_service_unittest.cc

+++ b/components/sync_driver/device_info_sync_service_unittest.cc

@@ -77,9 +77,9 @@ class DeviceInfoSyncServiceTest : public testing::Test,

public DeviceInfoTracker::Observer {

public:

DeviceInfoSyncServiceTest() : num_device_info_changed_callbacks_(0) {}

- virtual ~DeviceInfoSyncServiceTest() {}

+ ~DeviceInfoSyncServiceTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

local_device_.reset(new LocalDeviceInfoProviderMock(

"guid_1",

"client_1",

@@ -93,9 +93,7 @@ class DeviceInfoSyncServiceTest : public testing::Test,

sync_service_->AddObserver(this);

}

- virtual void TearDown() override {

- sync_service_->RemoveObserver(this);

- }

+ void TearDown() override { sync_service_->RemoveObserver(this); }

void OnDeviceInfoChange() override { num_device_info_changed_callbacks_++; }