components/sync_driver/device_info_data_type_controller_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_data_type_controller_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/data_type_manager_impl_unittest.cc ('k') | components/sync_driver/device_info_sync_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/device_info_data_type_controller_unittest.cc

diff --git a/components/sync_driver/device_info_data_type_controller_unittest.cc b/components/sync_driver/device_info_data_type_controller_unittest.cc

index c6535cbb5ef28ca2f160c3a69f07ad9312e613ea..aae85288cd4dcc4510d0716946ad4f520c44b557 100644

--- a/components/sync_driver/device_info_data_type_controller_unittest.cc

+++ b/components/sync_driver/device_info_data_type_controller_unittest.cc

@@ -23,9 +23,9 @@ class DeviceInfoDataTypeControllerTest : public testing::Test,

: load_finished_(false),

weak_ptr_factory_(this),

last_type_(syncer::UNSPECIFIED) {}

- virtual ~DeviceInfoDataTypeControllerTest() {}

+ ~DeviceInfoDataTypeControllerTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

local_device_.reset(new LocalDeviceInfoProviderMock(

"cache_guid",

"Wayne Gretzky's Hacking Box",

@@ -45,7 +45,7 @@ class DeviceInfoDataTypeControllerTest : public testing::Test,

last_error_ = syncer::SyncError();

}

- virtual void TearDown() override {

+ void TearDown() override {

controller_ = NULL;

local_device_.reset();

}