components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/media_transfer_protocol_device_observer_linux.h ('k') | components/storage_monitor/storage_monitor_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc

diff --git a/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc b/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc

index f39ccdfdc7a6aad0992937323fa35412c0087007..10f6e9a2fa2e6e0e41d9c808bb832ae7d6ac750e 100644

--- a/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc

+++ b/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc

@@ -96,10 +96,10 @@ class MediaTransferProtocolDeviceObserverLinuxTest : public testing::Test {

MediaTransferProtocolDeviceObserverLinuxTest()

: thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}

- virtual ~MediaTransferProtocolDeviceObserverLinuxTest() {}

+ ~MediaTransferProtocolDeviceObserverLinuxTest() override {}

protected:

- virtual void SetUp() override {

+ void SetUp() override {

mock_storage_observer_.reset(new MockRemovableStorageObserver);

TestStorageMonitor* monitor = TestStorageMonitor::CreateAndInstall();

mtp_device_observer_.reset(

@@ -108,7 +108,7 @@ class MediaTransferProtocolDeviceObserverLinuxTest : public testing::Test {

monitor->AddObserver(mock_storage_observer_.get());

}

- virtual void TearDown() override {

+ void TearDown() override {

StorageMonitor* monitor = StorageMonitor::GetInstance();

monitor->RemoveObserver(mock_storage_observer_.get());

mtp_device_observer_.reset();