components/storage_monitor/media_transfer_protocol_device_observer_linux.h - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/media_transfer_protocol_device_observer_linux.h

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/media_storage_util_unittest.cc ('k') | components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/media_transfer_protocol_device_observer_linux.h

diff --git a/components/storage_monitor/media_transfer_protocol_device_observer_linux.h b/components/storage_monitor/media_transfer_protocol_device_observer_linux.h

index 3b9d122764dc5940ab9e16f8508f1ae8027356af..50467adf3ad1f7a7e84916f044ee4e6bc37a9201 100644

--- a/components/storage_monitor/media_transfer_protocol_device_observer_linux.h

+++ b/components/storage_monitor/media_transfer_protocol_device_observer_linux.h

@@ -37,7 +37,7 @@ class MediaTransferProtocolDeviceObserverLinux

MediaTransferProtocolDeviceObserverLinux(

StorageMonitor::Receiver* receiver,

device::MediaTransferProtocolManager* mtp_manager);

- virtual ~MediaTransferProtocolDeviceObserverLinux();

+ ~MediaTransferProtocolDeviceObserverLinux() override;

// Finds the storage that contains |path| and populates |storage_info|.

// Returns false if unable to find the storage.

@@ -56,8 +56,8 @@ class MediaTransferProtocolDeviceObserverLinux

// device::MediaTransferProtocolManager::Observer implementation.

// Exposed for unit tests.

- virtual void StorageChanged(bool is_attached,

- const std::string& storage_name) override;

+ void StorageChanged(bool is_attached,

+ const std::string& storage_name) override;

private:

// Mapping of storage location and mtp storage info object.