components/password_manager/core/browser/password_generation_manager_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc

index 90d80249d2a6373e415646675c725712deb7eb2d..e67620f36a9c60b4ce6502d03a93e5f06023f4f5 100644

--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc

@@ -111,7 +111,7 @@ class TestAutofillMetrics : public autofill::AutofillMetrics {

class PasswordGenerationManagerTest : public testing::Test {

protected:

- virtual void SetUp() override {

+ void SetUp() override {

// Construct a PrefService and register all necessary prefs before handing

// it off to |client_|, as the initialization flow of |client_| will

// indirectly cause those prefs to be immediately accessed.

@@ -121,7 +121,7 @@ class PasswordGenerationManagerTest : public testing::Test {

client_.reset(new TestPasswordManagerClient(prefs.Pass()));

}

- virtual void TearDown() override { client_.reset(); }

+ void TearDown() override { client_.reset(); }

PasswordGenerationManager* GetGenerationManager() {

return client_->GetDriver()->GetPasswordGenerationManager();